Fix RGB JPEG embedded as DeviceGray (0.19.0 regression)#1734
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix regression in RGB JPEGs rendering as DeviceGray
Fix RGB JPEG embedded as DeviceGray (0.19.0 regression)
Jun 9, 2026
Member
|
@copilot discard yarn lock file changes |
Contributor
Author
Done — reverted the yarn.lock changes in 3df0d1e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An incorrect lint autofix in
38dd4359achangedthis.data[pos++]tothis.data[pos + 1]instead of the correctthis.data[pos]when reading the component count from a JPEG SOF segment. This caused all standard RGB JPEGs to be labeledDeviceGray(component id1) instead ofDeviceRGB(component count3), rendering them grayscale.Changes
lib/image/jpeg.js: Correct the byte offset — readthis.data[pos](theNfcomponent-count byte) instead ofthis.data[pos + 1](the first component's identifier).tests/unit/image.spec.js: Add regression test asserting that a standard RGB JPEG parses withcolorSpace === 'DeviceRGB'.